majamalu
Active Member
- Aug 28, 2015
- 144
- 775
I could be wrong, but judging by the millions of dollars that are regularly thrown into senseless "blockchain" projects, I still think many of them have probably been misled.
EDIT: missing wordLet us conjecture that the formation of moral values in society doesn’t come from the evolution of the consensus. No, it is the most intolerant person who imposes virtue on others precisely because of that intolerance. The same can apply to civil rights.
Why a single huge commit?
This development was conducted privately while I was learning about the Bitcoin code, and the full commit history is long and messy. Up to the first code release there have been 317 commits since March 7, 2016. I still maintain several unclean experimental feature branches.
It would take large effort to straighten it out into a series of nice, atomic functional commits. I'm not even sure that's always entirely possible with this set of changes, at least not while keeping things compiling between certain commits.
Therefore, instead of trying to re-arrange the commit history, I have carefully marked modifications with tagged change markers that identify the functional area(s) to which a change is associated. This has been done where possible - for some files it is not possible as they permit no comments etc.
The marker tags should make it relatively easy to understand what a change is about and to focus on a set of changes of interest for review.
I agree with those who would have preferred a clean, public development with an easily understandable commit history. I'm sorry I couldn't provide that with this first prototype. My future work on improved spin-offs will be conducted using public repositories, and thus it should be easier to understand and review changes.
Gavin put the Kaibosh on that kind of thing with his "I can't support Bitcoin Unlimited because the code in git is too messy so I'm going to go ahead and help create yet another fork that will drag things out another few months".@freetrader
Ah ok, thanks.
Makes a review pretty hard, no chance for a cleaned up history?
edit: And before that sounds to pessimistic, thanks for putting something out there that can be picked to pieces!