- Dec 16, 2015
- 2,806
- 6,088
@theZerg : Rather than publishing selected excerpts from that meeting to paint a particular picture, I will publish the full log of the meeting which I published in the release_admin Slack channel today for other developers to review. You clearly wish to conduct the further examination of the details on this public forum, so I will include also our further conversation on this topic, in full, to save both of us some time in re-stating points already made. And after all, your view was that on this subject there can be no expectation of privacy.@freetrader and I have been talking about things on slack. Ironically, he has logs of that day and they strongly support what I'm saying. With his permission I'll post the same excerpts as I posted on the slack.
Full log of 6 June 2017 developer meeting:
https://gist.github.com/ftrader/d390270da87055538b06989c4c4e7c20
Full log of further conversation on this matter between us, 5-6 April 2018 in same channel
https://gist.github.com/ftrader/74ee4584b56732a5d15678fba7a8c3d2
For those tempted to read only the second part, it contains selective quoting from the meeting which omits the reservations of other developers present to the proposed plan, and only quotes the single other developer who expressed support for it.
The meeting log also does not reflect the events that transpired sometime afterward, where thezerg clarified with me via DM what the status was at the end of the meeting. (since you might have noticed my hesitation to accept the proposed plan - I never expressed my satisfaction with it during the meeting). That brief follow-up conversation doesn't warrant a separate gist:
During the 6 June meeting I set up a HF branch on my personal repository on which to accept PRs.thezerg 4:47 PM
so are you going to accept daily merge responsibility for this project or not?
freetrader 4:48 PM
on my own repo ?
I thought I already said so
thezerg 4:48 PM
ok great
I will remove the buip055 branch from BU
After the above conversation, I wrote up a document to describe the proposed workflow and submitted it as the first PR on the same day. I also sent the PR link to other devs to get feedback. I recall it might have received informal acceptance (via Slack remarks) but It got a formal approval nod by a BU dev a week later (13 Jun) and I merged it into my 'buip-hf' branch on Jun 18.
On the same day as the meeting (6 Jun), deadalnix also submitted a PR for the replay protection to my repo. This was marked as "Can be modified is the spec ends up being different than what's proposed" and showed up with a failing test on Travis, so it was evidently a work in progress. A BU developer commented about the precise test which failed, but no other BU devs left any review comments on this one. It was clearly not in a ready state for merging.
@theZerg submitted what was the first and only PR submitted by another BU developer to my repository on 27 Jun. The initial title was 'WIP BUIP055' - WIP standing for 'work in progress'. It contained further fork related code. I examined it when it was submitted, but did not enter review comments into Github as the PR was marked by the author as WIP and was clearly in an unfinished state. Deadalnix reviewed it on the initial submission day as well, and made some review comments which were addressed. Later some more commits were added by others and pushed to the PR, and the title was changed to 'BUIP055' on 11 July. Shortly thereafter (14 July) another BU developer (sickpig) reviewed it, leaving review comments addressed to the author(s) of code sections in the PR. These review comments were not addressed at all by the BU developer. Long story short - this PR had not completed its review and was not ready for merging yet. Further commits were pushed to this PR until 21 July, but the review comments were not resolved.
Sometime after 14 July but before 18 July - I cannot reconstruct this exactly - thezerg decided to move BUIP55 development back to BU's main repository 'dev' branch in order to expedite the release.
I submitted a PR for difficulty adjustment on 18 July - a consensus change that came very late in the development - to BU's repo, where it was reviewed and finalized (merged) on 21 July.
On 24 July I received the following DM from thezerg on Slack which I shall enter into the record here.
I responded:thezerg 6:51 PM
So what happened? You never evaluated or commented on any of the BU PRs, never made any PRs of your own, etc.
Clearly there was a mismatch of expectations starting at the initial meeting. But no dissatisfaction was registered by thezerg prior to taking back the development to BU's repo.freetrader 6:54 PM
The deal was that other BU devs would review them, and none of them were in adequate post-review shape for me to construct PRs back to BU's repo.
Before that happened, you decided to take development back to BU dev .
Where I made a PR .
I kept my end.
FYI: I did evaluate your main PR made to my repo, in early stage.
It was clearly WIP - although I don't remember if it was marked as WIP.
The record shows that I did submit PRs, review PRs (although at a stage too early to make constructive comments). I could not merge the two PRs in my own repo as they were blocked in review.
I don't see how I could have sped up the development process for BU's release given the constraints at the time. In hindsight I should have not accepted this proposed method of working at the outset. But sometimes you can't predict how things will turn out.